Partial support of reset gate in cirq_google protos #7095
Merged
dstrain115 merged 8 commits intoquantumlib:mainfrom Feb 26, 2025
Merged
Partial support of reset gate in cirq_google protos #7095dstrain115 merged 8 commits intoquantumlib:mainfrom
dstrain115 merged 8 commits intoquantumlib:mainfrom
Conversation
- We have no need for this parameter and it is pretty much always set to the most permissive parameter. - Removes this parameter to simplify serialization.
- This change adds reset gate to the list of gates and adds a default deserialization to cirq.ResetChannel. - Other internal hardware reset mechanisms are not yet supported, and will be added later using custom deserializers.
dstrain115
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7095 +/- ##
==========================================
- Coverage 98.17% 98.16% -0.01%
==========================================
Files 1089 1089
Lines 95177 95192 +15
==========================================
+ Hits 93438 93448 +10
- Misses 1739 1744 +5 ☔ View full report in Codecov by Sentry. |
dstrain115
requested review from
a team,
verult,
vtomole and
wcourtney
as code owners
pavoljuhas
reviewed
Feb 25, 2025
pavoljuhas
approved these changes
Feb 25, 2025
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
LGTM with a minor comment.
senecameeks
reviewed
Feb 25, 2025
| dimensions = arg_func_langs.arg_from_proto( | ||
| operation_proto.resetgate.arguments.get('dimension', 2) | ||
| ) | ||
| assert isinstance( |
Collaborator
There was a problem hiding this comment.
nit: prefer not to use assert in non test files
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
* Remove arg_function_language - We have no need for this parameter and it is pretty much always set to the most permissive parameter. - Removes this parameter to simplify serialization. * Fix some typecheck stuff. * Fix test * Address comments. * Partial support of reset gate in cirq_google protos - This change adds reset gate to the list of gates and adds a default deserialization to cirq.ResetChannel. - Other internal hardware reset mechanisms are not yet supported, and will be added later using custom deserializers. * Address comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a default deserialization to cirq.ResetChannel.
and will be added later using custom deserializers.